[GitHub] [skywalking] kezhenxu94 opened a new issue #5770: [Python] Make the decorator `trace` support `async`, `await` functions

Tue, 03 Nov 2020 05:57:50 -0800 


kezhenxu94 opened a new issue #5770:
URL: https://github.com/apache/skywalking/issues/5770


   Currently the decorator `@trace` only support plain functions. Decorating 
functions with `async` makes the trace hierarchy incorrect.
   
   ```python
           @runnable()
           async def test1(self):
               return '1'
   
           @runnable()
           async def test2(self):
               return self.test1()
   
           def test(self):
               asyncio.run(self.test2())
   ```
   
   this generates the trace like this
   
![image](https://user-images.githubusercontent.com/15965696/97840852-bacb2800-1d1f-11eb-9361-23abc56b3606.png)
   
   while expectation is 
   
![image](https://user-images.githubusercontent.com/15965696/97840875-c3bbf980-1d1f-11eb-9e60-9d1fd23a7c91.png)
   
   
   @taskmgr , if you're interested in this, comment here and I can assign to 
you, FYI @WillemJiang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to