[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5796: Add branch protection and status check require

Thu, 05 Nov 2020 00:39:26 -0800 


kezhenxu94 commented on a change in pull request #5796:
URL: https://github.com/apache/skywalking/pull/5796#discussion_r517875170



##########
File path: .asf.yaml
##########
@@ -31,3 +31,15 @@ github:
     squash:  true
     merge:   false
     rebase:  false
+  protected_branches:
+    master:
+      required_status_checks:
+        strict: true
+        contexts:
+          - CI
+          - Single
+          - Storage
+          - Cluster

Review comment:
       These contexts are not exactly the same as what we see in the PR page, 
thus I fork and set in my forked repo and use GitHub API to see what the 
`context` is, hopefully it's right
   
   
![image](https://user-images.githubusercontent.com/15965696/98217309-4abddb80-1f85-11eb-9351-0a4480d0aa90.png)
   
![image](https://user-images.githubusercontent.com/15965696/98217329-51e4e980-1f85-11eb-8638-f3394e60ab5c.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to