dmsolr commented on a change in pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#discussion_r517977837
########## File path: apm-sniffer/apm-sdk-plugin/asynchttpclient-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asynchttpclient/v1/AsyncHandlerWrapper.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.apm.plugin.asynchttpclient.v1; + +import io.netty.channel.Channel; +import io.netty.handler.codec.http.HttpHeaders; +import java.net.InetSocketAddress; +import java.util.List; +import javax.net.ssl.SSLSession; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.asynchttpclient.AsyncCompletionHandlerBase; +import org.asynchttpclient.AsyncHandler; +import org.asynchttpclient.HttpResponseBodyPart; +import org.asynchttpclient.HttpResponseStatus; +import org.asynchttpclient.netty.request.NettyRequest; + +/** + * {@link AsyncHandlerWrapper} wrapper the {@link AsyncHandler} object for tracing. + * if userAsyncHandler is null, we will set {@link AsyncCompletionHandlerBase} to avoid NPE. + */ +public class AsyncHandlerWrapper implements AsyncHandler { + + private final AsyncHandler userAsyncHandler; + private final AbstractSpan asyncSpan; + + public AsyncHandlerWrapper(AsyncHandler asyncHandler, AbstractSpan span) { + this.userAsyncHandler = asyncHandler == null ? new AsyncCompletionHandlerBase() : asyncHandler; + this.asyncSpan = span; + } + + @Override + public State onStatusReceived(final HttpResponseStatus httpResponseStatus) throws Exception { + return userAsyncHandler.onStatusReceived(httpResponseStatus); + } + + @Override + public State onHeadersReceived(final HttpHeaders httpHeaders) throws Exception { + return userAsyncHandler.onHeadersReceived(httpHeaders); + } + + @Override + public State onBodyPartReceived(final HttpResponseBodyPart httpResponseBodyPart) throws Exception { + return userAsyncHandler.onBodyPartReceived(httpResponseBodyPart); + } + + @Override + public State onTrailingHeadersReceived(final HttpHeaders headers) throws Exception { + return userAsyncHandler.onTrailingHeadersReceived(headers); + } + + @Override + public void onThrowable(final Throwable throwable) { + asyncSpan.log(throwable); + asyncSpan.asyncFinish(); + userAsyncHandler.onThrowable(throwable); + } + + @Override + public Object onCompleted() throws Exception { + asyncSpan.asyncFinish(); + return userAsyncHandler.onCompleted(); + } Review comment: Note that, must be avoided to interrupt the process of the application in the wrapper class. ########## File path: apm-sniffer/apm-sdk-plugin/asynchttpclient-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asynchttpclient/v1/ExecuteInterceptor.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.apm.plugin.asynchttpclient.v1; + +import io.netty.handler.codec.http.HttpHeaders; +import java.lang.reflect.Method; +import org.apache.skywalking.apm.agent.core.context.CarrierItem; +import org.apache.skywalking.apm.agent.core.context.ContextCarrier; +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.tag.Tags; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; +import org.asynchttpclient.AsyncHandler; +import org.asynchttpclient.Request; +import org.asynchttpclient.uri.Uri; + +/** + * interceptor for {@link org.asynchttpclient.DefaultAsyncHttpClient} + */ +public class ExecuteInterceptor implements InstanceMethodsAroundInterceptor { + + @Override + public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, + Class<?>[] argumentsTypes, MethodInterceptResult result) throws Throwable { + + final Request httpRequest = (Request) allArguments[0]; + final Uri requestUri = httpRequest.getUri(); + + AbstractSpan span = ContextManager.createExitSpan( + "AsyncHttpClient" + requestUri.getPath(), requestUri.getHost() + ":" + requestUri.getPort()); + + /** + * We wrapper the allArguments[1] for get the real time duration, and stop the span. + */ Review comment: Change to single-line comment ########## File path: apm-sniffer/apm-sdk-plugin/asynchttpclient-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asynchttpclient/v1/AsyncHandlerWrapper.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.apm.plugin.asynchttpclient.v1; Review comment: what does the `v1` mean? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
