kezhenxu94 commented on a change in pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#discussion_r518520232



##########
File path: 
oap-server/server-receiver-plugin/receiver-proto/src/main/fbs/istio/node-info.fbs
##########
@@ -0,0 +1,48 @@
+/* Copyright 2020 Istio Authors. All Rights Reserved.

Review comment:
       Yes, I'll configure a maven phase to download this before compiling, 
with a URL format like this, the commit SHA is a property that can be specified 
(the necessity needs discussion though) 
`https://raw.githubusercontent.com/istio/proxy/94a7d9942aa8181f688933cb265879d59a0d85dd/extensions/common/node_info.fbs`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to