hanahmily commented on a change in pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#discussion_r528463297
##########
File path:
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Expression.java
##########
@@ -23,18 +23,35 @@
import groovy.lang.GroovyObjectSupport;
import groovy.util.DelegatingScript;
import java.time.Instant;
+import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
/**
* Expression is a reusable monadic container type which represents a DSL
expression.
*/
@Slf4j
+@RequiredArgsConstructor
public class Expression {
+ private final String literal;
+
private final DelegatingScript expression;
- Expression(DelegatingScript expression) {
- this.expression = expression;
+ /**
+ * Parse the expression statically.
+ *
+ * @return Parsed context of the expression.
+ */
+ public ExpressionParsingContext parse() {
+ try (ExpressionParsingContext ctx = ExpressionParsingContext.create())
{
+ ctx.downsampling = DownsamplingType.AVG;
Review comment:
done
##########
File path:
oap-server/server-bootstrap/src/main/resources/oc-rules/istio-controlplane.yaml
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This will parse a textual representation of a duration. The formats
+# accepted are based on the ISO-8601 duration format {@code PnDTnHnMn.nS}
+# with days considered to be exactly 24 hours.
+# <p>
+# Examples:
+# <pre>
+# "PT20.345S" -- parses as "20.345 seconds"
+# "PT15M" -- parses as "15 minutes" (where a minute is 60 seconds)
+# "PT10H" -- parses as "10 hours" (where an hour is 3600 seconds)
+# "P2D" -- parses as "2 days" (where a day is 24 hours or 86400
seconds)
+# "P2DT3H4M" -- parses as "2 days, 3 hours and 4 minutes"
+# "P-6H3M" -- parses as "-6 hours and +3 minutes"
+# "-P6H3M" -- parses as "-6 hours and -3 minutes"
+# "-P-6H+3M" -- parses as "+6 hours and -3 minutes"
+# </pre>
+enabled: true
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
