jdyer1 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1402380551
##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##########
@@ -186,13 +191,14 @@ protected ServletFileUpload
createServletFileUpload(DiskFileItemFactory fac) {
}
protected DiskFileItemFactory createDiskFileItemFactory(String saveDir) {
- DiskFileItemFactory fac = new DiskFileItemFactory();
+ DiskFileItemFactory.Builder fac = DiskFileItemFactory.builder();
// Make sure that the data is written to file, even if the file is
empty.
- fac.setSizeThreshold(-1);
+ //setting 0 or -1 no longer seems to work for fileupload buffer size,
so using 1 instead.
+ fac.setBufferSize(1);
if (saveDir != null) {
- fac.setRepository(new File(saveDir));
+ fac.setPath(saveDir);
Review Comment:
Maybe this is a question for the commons-upload dev list? I wonder, also,
is it vital that Struts be able to tell the difference between a missing file
and an empty file? This is the only problem we are having here, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
