lukaszlenart commented on code in PR #791:
URL: https://github.com/apache/struts/pull/791#discussion_r1405349701
##########
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##########
@@ -385,6 +386,7 @@ protected Container
createBootstrapContainer(List<ContainerProvider> providers)
builder.factory(ExpressionCacheFactory.class,
DefaultOgnlExpressionCacheFactory.class, Scope.SINGLETON);
builder.factory(BeanInfoCacheFactory.class,
DefaultOgnlBeanInfoCacheFactory.class, Scope.SINGLETON);
builder.factory(OgnlUtil.class, Scope.SINGLETON);
+ builder.factory(SecurityMemberAccess.class, Scope.PROTOTYPE);
Review Comment:
I meant it will be possible creating a new instance via `container`s
methods, yet we excluded the whole package `com.opensymphony.xwork2.inject`
which means attacker cannot use container in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
