kusalk commented on code in PR #830:
URL: https://github.com/apache/struts/pull/830#discussion_r1440272476
##########
plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java:
##########
@@ -673,17 +697,17 @@ protected void buildConfiguration(Set<Class> classes) {
for (String namespace : namespaces) {
String defaultActionName = determineActionName(actionClass);
PackageConfig.Builder defaultPackageConfig =
getPackageConfig(packageConfigs, namespace,
- actionPackage, actionClass, null);
+ actionPackage, actionClass, null);
// Verify that the annotations have no errors and also
determine if the default action
// configuration should still be built or not.
Map<String, List<Action>> map =
getActionAnnotations(actionClass);
Set<String> actionNames = new HashSet<>();
boolean hasDefaultMethod =
ReflectionTools.containsMethod(actionClass, DEFAULT_METHOD);
if (!map.containsKey(DEFAULT_METHOD)
- && hasDefaultMethod
- && actionAnnotation == null && actionsAnnotation ==
null
- && (alwaysMapExecute || map.isEmpty())) {
+ && hasDefaultMethod
+ && actionAnnotation == null && actionsAnnotation == null
+ && (alwaysMapExecute || map.isEmpty())) {
Review Comment:
My personal preference is to use double indents for continuations - it
avoids situations like these where the guard blends in with the following code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
