kusalk commented on code in PR #867:
URL: https://github.com/apache/struts/pull/867#discussion_r1475594710
##########
plugins/osgi/src/main/java/org/apache/struts2/osgi/OsgiConfigurationProvider.java:
##########
@@ -255,16 +254,27 @@ public void setBundleAccessor(BundleAccessor acc) {
}
@Inject
- public void setVelocityManager(VelocityManager vm) {
- LOG.trace("OSGi ConfigurationProvider - setVelocityManager() called -
VelocityManager: [{}]", vm);
-
+ public void setVelocityManager(VelocityManagerInterface vmi) {
+ LOG.trace("OSGi ConfigurationProvider - setVelocityManager() called -
VelocityManager: [{}]", vmi);
+ if (!(vmi instanceof VelocityManager)) {
Review Comment:
Didn't bother with a marker interface here as this plugin is deprecated
anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
