brianandle commented on code in PR #898: URL: https://github.com/apache/struts/pull/898#discussion_r1541143712
########## core/src/main/java/org/apache/struts2/interceptor/ParameterAware.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.struts2.interceptor; + +import org.apache.struts2.dispatcher.HttpParameters; + +import java.util.Map; + +@Deprecated +public interface ParameterAware extends org.apache.struts2.action.ParametersAware { + + void setParameters(Map map); + + @Override + default void withParameters(HttpParameters parameters) { + setParameters(parameters); Review Comment: Yup, the 0.3 confused me as well as it deviate from SemVer but I assumed it was just habit. :) The caffeine was more of a note of what I found as I tried to get our app running on latest. Since 6.4 hasn't been released I didn't have release notes to dig into. Seems like almost all the breakages I hit were introduced in 6.2. Maybe your approach icould be used and bundled together as a compatibility plugin/seperate jar? That might not be possible in all cases but maybe helps the teams goals of deprecation "removal" while abstraction into its own jar. My largest concern based on past historical Struts usage is I expect a lot of usages sitting on 2.5 after EOL and when a new security issue is released scrambling and hitting similar upgrade issues and likely not being able to upgrade in a timely manor. I do want to say I deeply appreciate the teams time and effort on the ongoing maintenance and improvements of Struts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
