kusalk commented on code in PR #912:
URL: https://github.com/apache/struts/pull/912#discussion_r1560203638
##########
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##########
@@ -459,9 +460,12 @@ protected synchronized RuntimeConfiguration
buildRuntimeConfiguration() throws C
boolean appendNamedParameters = Boolean.parseBoolean(
container.getInstance(String.class,
StrutsConstants.STRUTS_MATCHER_APPEND_NAMED_PARAMETERS)
);
+ boolean fallbackToEmptyNamespace = Boolean.parseBoolean(
+ Optional.ofNullable(container.getInstance(String.class,
StrutsConstants.STRUTS_ACTION_CONFIG_FALLBACK_TO_EMPTY_NAMESPACE)).orElse("true")
Review Comment:
@jefferyxhy and I just discussed this one and one of the drawbacks of
putting it in `default.properties` is that it isn't read by unit tests and
causes a bunch of test failures, as the unit tests will default to `false`. To
get around this we could additionally add the constant to
`StrutsDefaultConfigurationProvider` as well as `default.properties`.
I'm personally not too fussed. In the past I've deliberately made constants
default to false to try sidestep this issue. Let us know know what you would
prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
