lukaszlenart commented on code in PR #914:
URL: https://github.com/apache/struts/pull/914#discussion_r1562038780
##########
core/src/main/java/org/apache/struts2/config/StrutsXmlConfigurationProvider.java:
##########
@@ -54,6 +54,7 @@ public class StrutsXmlConfigurationProvider extends
XmlConfigurationProvider {
put("-//Apache Software Foundation//DTD Struts Configuration 2.3//EN",
"struts-2.3.dtd");
put("-//Apache Software Foundation//DTD Struts Configuration 2.5//EN",
"struts-2.5.dtd");
put("-//Apache Software Foundation//DTD Struts Configuration 6.0//EN",
"struts-6.0.dtd");
+ put("-//Apache Software Foundation//DTD Struts Configuration
6.5.0//EN", "struts-6.5.0.dtd");
Review Comment:
I would keep two digits pattern as such changes cannot be introduced with
`PATCH` version anyway. So instead of
```java
put("-//Apache Software Foundation//DTD Struts Configuration 6.5.0//EN",
"struts-6.5.0.dtd")
```
use
```java
put("-//Apache Software Foundation//DTD Struts Configuration 6.5//EN",
"struts-6.5.dtd")
```
and rename the corresponding file.
---
What do you think? does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
