lukaszlenart commented on code in PR #932:
URL: https://github.com/apache/struts/pull/932#discussion_r1597396861


##########
core/src/main/java/org/apache/struts2/interceptor/exec/StrutsBackgroundProcess.java:
##########
@@ -61,11 +66,17 @@ public BackgroundProcess prepare() {
                 try {
                     beforeInvocation();
                     result = invocation.invokeActionOnly();
-                    afterInvocation();
                 } catch (Exception e) {
+                    LOG.warn("Exception during invokeActionOnly() execution", 
e);
                     exception = e;
                 } finally {
-                  done = true;
+                    try {
+                        afterInvocation();
+                    } catch (Exception ex) {
+                        exception = ex;

Review Comment:
   Right, let's keep it simple, I will set `exception` only if wasn't already 
set



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to