kusalk commented on code in PR #967:
URL: https://github.com/apache/struts/pull/967#discussion_r1668086483
##########
core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessTest.java:
##########
@@ -931,6 +981,15 @@ public void packageInclusion_subclass_both() throws
Exception {
private static String formGetterName(String propertyName) {
return "get" + propertyName.substring(0, 1).toUpperCase() +
propertyName.substring(1);
}
+
+ @SuppressWarnings("unchecked")
+ private static <T> T mockHibernateProxy(T originalObject, Class<T>
proxyInterface) {
Review Comment:
Mocking a Hibernate proxy isn't perfect - integration/acceptance tests would
offer better protection against regressions but I'd prefer not to complicate
the tests further by introducing a Hibernate session factory etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
