lukaszlenart commented on code in PR #986:
URL: https://github.com/apache/struts/pull/986#discussion_r1677041654
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/Allowed.java:
##########
@@ -28,9 +28,11 @@
* a HttpRequest parameter.
*
* @author martin.gilday
+ * @deprecated since 6.6.0, use {@link
org.apache.struts2.interceptor.parameter.StrutsParameter}.
Review Comment:
❤️
##########
core/src/test/java/org/apache/struts2/ExecutionCountTestAction.java:
##########
@@ -41,9 +41,10 @@ public int getExecutionCount() {
return executionCount;
}
+ @Override
public String execute() throws Exception {
executionCount++;
- LOG.info("executing ExecutionCountTestAction. Current count is " +
executionCount);
+ LOG.info("executing ExecutionCountTestAction. Current count is {}",
executionCount);
Review Comment:
❤️
##########
plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ShowConfigAction.java:
##########
@@ -98,16 +104,17 @@ public PropertyDescriptor[] getProperties() {
return properties;
}
+ @Override
public String execute() throws Exception {
super.execute();
config = configHelper.getActionConfig(namespace, actionName);
- actionNames = new
TreeSet<String>(configHelper.getActionNames(namespace));
+ actionNames = new TreeSet<>(configHelper.getActionNames(namespace));
try {
Object action = objectFactory.buildAction(actionName, namespace,
config, null);
properties = reflectionProvider.getPropertyDescriptors(action);
} catch (Exception e) {
- LOG.error("Unable to get properties for action " + actionName, e);
- addActionError("Unable to retrieve action properties: " +
e.toString());
+ LOG.error("Unable to get properties for action {}", actionName, e);
Review Comment:
This won't work, you must use `ParameterizedMessage` like this
```java
LOG.error(new ParameterizedMessage("Unable to get properties for action {}",
actionName), e);
```
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationParameterFilterInterceptor.java:
##########
@@ -46,7 +46,10 @@
* </p>
*
* @author martin.gilday
+ * @deprecated since 6.6.0, integrated into {@link ParametersInterceptor} with
{@link StrutsParameter} using
Review Comment:
Do we have a task to remove this interceptor in Struts 7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
