kusalk commented on PR #1071: URL: https://github.com/apache/struts/pull/1071#issuecomment-2407132158
It seems that the `java.beans.PropertyDescriptor` API will always return the getter method on the `ModelDriven` interface rather than the Action (I didn't actually realise this when I wrote this feature). This means it doesn't matter if `getModel` on the actual Action class is annotated or not, it will only ever check the interface method. To be honest, I don't mind this behaviour - what if we just exempt all model driven Actions from the annotation requirement? The `@StrutsParameter` requirement was designed to protect against random getters/setters on the Action class from being injected. But if an Action is using a dedicated model object (and the Action class is indeed not on the root of the ValueStack) it is already much safer. Here is my alternative solution for your consideration: f67f593b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
