kusalk commented on code in PR #1232:
URL: https://github.com/apache/struts/pull/1232#discussion_r1968683115
##########
pom.xml:
##########
@@ -900,52 +806,12 @@
</dependency>
<dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
- <version>${jackson.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.juneau</groupId>
- <artifactId>juneau-marshall</artifactId>
- <version>8.1.3</version>
- </dependency>
Review Comment:
I moved version management for dependencies that are specific to only 1
plugin and are unlikely to ever be needed elsewhere as I thought it made the
root POM slightly neater. I did the same with the Weld dependencies which are
specific to the CDI plugin.
But I don't have a strong opinion here and am happy to revert these specific
changes, let me know what your preference is 🙂
It'd be good to be consistent though, so if we decide to keep them in the
root POM, I'd like to version manage the other dependencies that are currently
only defined in their plugins (e.g. `org.jfree:jfreechart`,
`net.sf.jasperreports:jasperreports` and any others).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
