kusalk commented on code in PR #1243:
URL: https://github.com/apache/struts/pull/1243#discussion_r1983329534
##########
core/src/main/java/org/apache/struts2/interceptor/ModelDrivenInterceptor.java:
##########
@@ -79,20 +81,27 @@
public class ModelDrivenInterceptor extends AbstractInterceptor {
protected boolean refreshModelBeforeResult = false;
+ private ThreadAllowlist threadAllowlist;
public void setRefreshModelBeforeResult(boolean val) {
this.refreshModelBeforeResult = val;
}
+ @Inject
+ public void setThreadAllowlist(ThreadAllowlist threadAllowlist) {
+ this.threadAllowlist = threadAllowlist;
+ }
+
@Override
public String intercept(ActionInvocation invocation) throws Exception {
Object action = invocation.getAction();
- if (action instanceof ModelDriven modelDriven) {
+ if (action instanceof ModelDriven<?> modelDriven) {
ValueStack stack = invocation.getStack();
Object model = modelDriven.getModel();
- if (model != null) {
- stack.push(model);
+ if (model != null) {
+ stack.push(model);
+ threadAllowlist.allowClassHierarchy(model.getClass());
Review Comment:
We OGNL allowlist the model class immediately in the
`ModelDrivenInterceptor` as we expect this class to be safe and accessible from
templates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
