lukaszlenart opened a new pull request, #1446:
URL: https://github.com/apache/struts/pull/1446
## Summary
Renames configuration constants from `struts.compress.*` to
`struts.tag.compress.*` to align with the established pattern for tag-specific
configuration in Apache Struts.
**Rationale**: The compress tag configuration should follow the
`struts.tag.*` namespace pattern used for tag-specific settings (similar to
`struts.tag.includetag.useResponseEncoding`), rather than a generic
feature-level namespace or the UI component namespace (`struts.ui.*`).
## Changes
- **StrutsConstants.java**: Updated 3 constant values:
- `STRUTS_COMPRESS_ENABLED` → `"struts.tag.compress.enabled"`
- `STRUTS_COMPRESS_MAX_SIZE` → `"struts.tag.compress.maxSize"`
- `STRUTS_COMPRESS_LOG_MAX_LENGTH` → `"struts.tag.compress.log.maxLength"`
- **default.properties**: Updated 3 property keys to match new namespace
- **Compress.java**: Updated JavaDoc reference to new property name
- **Documentation**: Updated all references in implementation plan
## Namespace Patterns
- `struts.tag.*` - Tag-specific configuration (e.g., `<s:compress>`,
`<s:include>`)
- `struts.ui.*` - UI component cross-cutting concerns (themes, templates)
- `struts.freemarker.*` - Template engine configuration
## Test Plan
- [x] All existing CompressTest tests pass (18/18)
- [x] No old `struts.compress.*` references remain in codebase
- [x] Configuration injection works correctly with new property names
- [x] `struts.freemarker.whitespaceStripping` remains unchanged
## Notes
These changes were introduced in PR #1418 but not yet released, so no
deprecation cycle is needed.
Closes [WW-5256](https://issues.apache.org/jira/browse/WW-5256)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
