ryanmurf commented on PR #1445: URL: https://github.com/apache/struts/pull/1445#issuecomment-3620983923
> Is this PR related to the latest CVE? I noticed that the cleanup commit for [WW-5573](https://github.com/apache/struts/commit/0f8c2e65580ccd7659c06734ccbd3cb722df67cf) handled exceptions in both the stream and non-stream multipart upload cleanup methods. The later [commit](https://github.com/apache/struts/commit/036c4ddb746a6ebadace1355ba99dcef4114977) added a try/catch block, but only for the non-stream path, so I updated the code to make the behavior consistent. For the other change, I noticed when running tests on older branches that a `NullPointerException` in `processNormalFormField` (fixed [here](https://github.com/apache/struts/commit/09eb2860207f9237b3326ea2100591771dadf3a5)) could prevent files from being added to `allFileItems`, resulting in them not being cleaned up. This change should also help ensure proper cleanup if a similar issue occurs while processing `FileItems`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
