lukaszlenart commented on PR #1776:
URL: https://github.com/apache/struts/pull/1776#issuecomment-4950856945

   Thanks for the patch, and especially the concurrency regression tests. The 
thread-safety problem is real — `StrutsJSONWriter` keeps per-write state on a 
shared instance. I'm merging this as the immediate fix.
   
   Longer term I'd rather address it at the lifecycle level in `JSONUtil` (a 
fresh instance per operation) rather than per-field `ThreadLocal`s, to avoid 
the cleanup contract. Tracked in 
[WW-5650](https://issues.apache.org/jira/browse/WW-5650), which will preserve 
your regression tests. Appreciate the contribution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to