deprrous opened a new pull request, #1815:
URL: https://github.com/apache/struts/pull/1815

   Follow-up to [WW-5585](https://issues.apache.org/jira/browse/WW-5585).
   
   When `allowedTypes`, `allowedExtensions`, or `maximumSize` are resolved 
lazily from `${...}`, those resolved values currently get written back onto the 
shared interceptor instance. That lets concurrent requests bleed into each 
other before file validation runs.
   
   This keeps the lazily resolved upload policy request-scoped for the lifetime 
of the interceptor call and clears it afterwards. Static interceptor 
configuration still behaves the same.
   
   Tests:
   - `./mvnw -pl core 
-Dtest=org.apache.struts2.interceptor.ActionFileUploadInterceptorTest#testConcurrentDynamicPoliciesStayIsolatedPerRequest
 test`
   - `./mvnw -pl core 
-Dtest=org.apache.struts2.interceptor.ActionFileUploadInterceptorTest,org.apache.struts2.DefaultActionInvocationTest
 test`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to