lukaszlenart opened a new pull request, #1886:
URL: https://github.com/apache/struts/pull/1886

   Follow-up to #1885 and #1876.
   
   `CLAUDE.md` and `.github/skills/code-review/SKILL.md` each stated how many 
test classes use the JUnit 3 and JUnit 4 styles. Both were already stale:
   
   | | `SKILL.md` | `CLAUDE.md` | actual |
   |---|---|---|---|
   | `extends XWorkTestCase` | ~117 | ~114 | **117** |
   | `import org.junit.Test` | ~212 | ~210 | **215** |
   | `org.junit.jupiter` | 0 | 0 | **0** |
   
   Both were hedged with "around"/"~", so neither was wrong today. But a count 
that only moves in one direction, duplicated across two files with nothing 
watching it, is a drift surface for no benefit — the numbers carry no review 
weight.
   
   What matters is retained: both styles are current, a new test must match the 
file it joins, and there are **zero** `org.junit.jupiter` imports. That last 
one is the load-bearing claim and it stays in both files.
   
   The two files serve different consumers — `CLAUDE.md` for Claude Code, 
`.github/skills/` for GitHub Copilot code review (#1876) — so they are updated 
in step rather than merged.
   
   Documentation only — no ticket, per the `docs:` convention in `CLAUDE.md`. 
No code, build or CI files touched.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01AtyHU8BzNmeZNncXRu7yjB


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to