carrerasdarren-cell commented on PR #1889: URL: https://github.com/apache/struts/pull/1889#issuecomment-5494477658
Thanks for the detailed review. Addressed in `514b92bf4`: - reject a detached any-setter parser when `currentName()` is null, before creating either authorization scope; - place both scope pushes under guarded `finally` cleanup; - clear dynamic-key request state after every Jackson JSON/XML mapper read, including exceptional exits; - make the module configuration flag `volatile`; and - clarify the ordinary query/form binding effect of placing `@StrutsParameter` on a field. I added regressions for the null-name token-buffer path and for request-boundary cleanup after a failed Jackson read. Verification after the update: 41 focused authorization tests pass, all 144 REST plugin tests pass, REST plugin `verify` and Apache RAT pass, and `git diff --check` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
