See 
<http://hudson.zones.apache.org/hudson/job/subversion-trunk-solaris/888/changes>

Changes:

[gstein] Remove a couple internal props functions.

* subversion/libsvn_wc/props.h:
  (svn_wc__has_props): removed
  (svn_wc__wcprop_set): declaration removed.

* subversion/libsvn_wc/props.c:
  (svn_wc__wcprop_set): renamed to ...
  (wcprop_set): ... this. made static. added comment about the
    transaction-ness of this function.
  (svn_wc__internal_propset): track rename to wcprop_set
  (svn_wc__has_props): removed

* subversion/libsvn_wc/status.c:
  (assemble_status): alter call to __has_props by fetching the pristine
    and current set of properties for the node. leave a note that we
    cannot (yet) rely on these for the __props_modified call.

[dannas] Change doc comment referring to traversal_info to talk about 
external_func 
instead. The status code has replaced the use of traversal_info with an
svn_wc_external_update_t callback.

* subversion/libsvn_wc/status.c
  (get_dir_status): See above.

[gstein] Fix up some subtle issues around dealing with properties in the 
database.
In particular, begin adjusting the wc_db functions to sometimes return
NULL for properties because they are not available given the state of the
node. Also fix the fetching of the pristine properties: a WORKING_NODE
could be deleting the node/props, so the pristines ARE in BASE_NODE.

Adjust some callers to deal with NULL return values. Further work here is
necessary, as this was not an exhaustive review.

* subversion/libsvn_wc/wc_db.h:
  (svn_wc__db_read_props, svn_wc__db_read_pristine_props): note that NULL
    may be returned.

* subversion/libsvn_wc/wc_db.c:
  (svn_wc__db_read_pristine_props): if the node is "base-deleted", then
    the pristines are in BASE_NODE (and we should ignore any that might
    have snuck into WORKING_NODE). expand some of the comments here.

* subversion/libsvn_wc/wc-queries.sql:
  (STMT_SELECT_WORKING_PROPS): we'll need the 'presence' column, too.

* subversion/libsvn_wc/props.c:
  (load_pristine_props): allow for a NULL return from wc_db and adjust the
    assertions made.
  (load_actual_props): allow for a NULL return from load_pristine_props,
    compensating with an empty set of props. also allow for a NULL from
    wc_db and adjust the assertions.
  (immediate_install_props): remove the BASE_PROPS param, and just fetch
    the pristines in here.
  (svn_wc__get_pristine_props): add some comments to clarify
  (svn_wc__internal_propset): no need to fetch the pristines, as
    immediate_install_props will do it now.
  (svn_wc__has_props): compensate for a NULL return. add some comments.
  (svn_wc__internal_propdiff): add question about NULL return from
    load_pristine_props.

* subversion/libsvn_wc/adm_ops.c:
  (mark_item_copied): compensate for a NULL set of pristine props

------------------------------------------
Started by an SCM change
Building remotely on lucene.zones.apache.org (Solaris 10)
Updating https://svn.apache.org/repos/asf/subversion/trunk
U         subversion/libsvn_wc/props.c
U         subversion/libsvn_wc/props.h
U         subversion/libsvn_wc/adm_ops.c
U         subversion/libsvn_wc/status.c
U         subversion/libsvn_wc/wc-queries.sql
U         subversion/libsvn_wc/wc_db.c
U         subversion/libsvn_wc/wc_db.h
At revision 942179
[subversion-trunk-solaris] $ /bin/bash -xe /var/tmp/hudson918744592029127229.sh
+ cd subversion-trunk
+ 
PATH=/export/home/hudson/bin:/export/home/hudson/tools/java/latest/bin:/export/home/hudson/tools/ant/latest/bin:/export/home/hudson/tools/tomcat/latest/bin:/opt/subversion-current/bin:/usr/ucb:/usr/local/bin:/usr/bin:/usr/sfw/bin:/usr/sfw/sbin:/opt/sfw/bin:/opt/sfw/sbin:/opt/SUNWspro/bin:/usr/X/bin:/usr/ucb:/usr/sbin:/usr/ccs/bin:/usr/bin
+ export PATH
+ /usr/ccs/bin/make clean
make: Fatal error: Don't know how to make target `clean'
Recording test results

Reply via email to