The GitHub Actions job "autoconf" on subversion.git/trunk has failed.
Run started by GitHub user asf-gitbox-commits (triggered by asf-gitbox-commits).

Head commit for run:
f9f57162357a0be89f4e07bf0c011b7c3c79e453 / Evgeny Kotkov <[email protected]>
ra_serf: Guard against SERF_VERSION_AT_LEAST(unreleased version) logic.

Before this change, our code contained several blocks of code conditional
on SERF_VERSION_AT_LEAST(1, 4, 0).  Since Serf 1.4.0 is unreleased, this
code relies on development snapshots rather than a stable API.

Essentially, that's a ticking timebomb.  The code encodes assumptions
about a development version of Serf but will automatically activate if
a user builds against an officially released Serf 1.4.0+.

More specifically:

- The code may not compile, depending on the final API state in Serf 1.4.0+.
- Even if it compiles, assumptions about Serf's behavior may no longer hold.
- Even if the assumptions hold, these code paths may still not work as intended,
  because they are effectively hidden from our standard release testing and
  buildbots.

To fix this issue, place such code under an additional guard (#ifdef
SVN__SERF_EXPERIMENTAL) that is never defined in production builds.

See [1] for additional details.

* subversion/libsvn_ra_serf/serf.c
  (load_config): Guard code with #ifdef SVN__SERF_EXPERIMENTAL.

* subversion/libsvn_ra_serf/update.c
  (get_best_connection): Guard code with #ifdef SVN__SERF_EXPERIMENTAL.

* subversion/libsvn_ra_serf/util.c
  (conn_negotiate_protocol, conn_setup, svn_ra_serf__default_readline):
   Guard code with #ifdef SVN__SERF_EXPERIMENTAL.

[1]: https://lists.apache.org/thread/7dpmb63wc1phqvgwvp9hnyrzfqpd2mz5


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1930808 
13f79535-47bb-0310-9956-ffa450edef68

Report URL: https://github.com/apache/subversion/actions/runs/20442320430

With regards,
GitHub Actions via GitBox

Reply via email to