The GitHub Actions job "autoconf" on subversion.git/proxy-move-copy-fix has 
failed.
Run started by GitHub user asf-gitbox-commits (triggered by asf-gitbox-commits).

Head commit for run:
5bb5ebe90d32c9257489f401771830cc4e816ed9 / Jordan Peck <[email protected]>
90% Fix issue #3445: don't rewrite versioned payload in the write-through proxy.

The slave's body-rewrite filters blindly substituted the slave location
path with the master's across entire request and response bodies,
corrupting versioned data: file content in PUT bodies and property values
in PROPPATCH bodies.  Only protocol XML (MERGE/CHECKOUT/REPORT bodies,
multistatus responses) carries hrefs the proxy must translate.

On the request side, stop attaching the rewrite input filter to PUT and
PROPPATCH requests at all.  On the response side, gate the body filter
on the response Content-Type: anything that isn't protocol XML is
versioned payload and passes through untouched.

A residual remains: a dead-property *value* containing the master
location inside a genuine multistatus is still rewritten along with the
hrefs, fixing that requires further work.  See the new FIXME comment.
Regression tests will be in a follow-up commit.

* subversion/mod_dav_svn/mirror.c
  (proxy_request_fixup): Don't add the IncomingRewrite input filter for
   PUT and PROPPATCH requests; their bodies are versioned payload.
  (dav_svn__location_in_filter): Drop the obsolete FIXME, the hazardous
   methods no longer reach this filter.
  (response_is_xml): New helper.
  (dav_svn__location_body_filter): Remove ourselves from the filter
   chain for non-XML responses.  Document the residual dead-property
   rewrite.

git-svn-id: 
https://svn.apache.org/repos/asf/subversion/branches/proxy-move-copy-fix@1936010
 13f79535-47bb-0310-9956-ffa450edef68

Report URL: https://github.com/apache/subversion/actions/runs/28972729054

With regards,
GitHub Actions via GitBox

Reply via email to