GabeLoins commented on issue #4914: [WiP] make MetricsControl the standard across visualizations URL: https://github.com/apache/incubator-superset/pull/4914#issuecomment-386670513 LGTM- yay super excited to see this happening. I think referring to metrics at the label level definitely seems better than keeping a mixed list of dicts and strings- glad to see that refactor.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
