williaster commented on a change in pull request #4893: add sticky to sidepane
URL:
https://github.com/apache/incubator-superset/pull/4893#discussion_r186224877
##########
File path: superset/assets/src/dashboard/containers/SliceAdder.js
##########
@@ -0,0 +1,32 @@
+import { bindActionCreators } from 'redux';
+import { connect } from 'react-redux';
+
+import { fetchAllSlices } from '../actions/sliceEntities';
+import SliceAdder from '../components/SliceAdder';
+
+function mapStateToProps(
+ { sliceEntities, dashboardInfo, dashboardState },
+ ownProps,
+) {
+ return {
+ userId: dashboardInfo.userId,
+ selectedSliceIds: dashboardState.sliceIds,
+ slices: sliceEntities.slices,
+ isLoading: sliceEntities.isLoading,
+ errorMessage: sliceEntities.errorMessage,
+ lastUpdated: sliceEntities.lastUpdated,
+ editMode: dashboardState.editMode,
+ height: ownProps.height,
Review comment:
why override a prop that it already has with the same value? you can just
remove this line and it will still have that prop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
