williaster commented on a change in pull request #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186229561
########## File path: superset/assets/src/dashboard/components/SliceHeaderControls.jsx ########## @@ -57,53 +64,44 @@ class SliceHeaderControls extends React.PureComponent { const slice = this.props.slice; const isCached = this.props.isCached; const cachedWhen = moment.utc(this.props.cachedDttm).fromNow(); - const refreshTooltip = isCached - ? t('Served from data cached %s . Click to force refresh.', cachedWhen) - : t('Force refresh data'); + const refreshTooltip = isCached ? t('Cached %s', cachedWhen) : ''; return ( - <DropdownButton - title="" + <Dropdown id={`slice_${slice.slice_id}-controls`} - className={cx('slice-header-controls-trigger', 'fa fa-ellipsis-v', { - 'is-cached': isCached, - })} + className={cx(isCached && 'is-cached')} pullRight - noCaret > - <ActionMenuItem - text={t('Force refresh data')} - tooltip={refreshTooltip} - onClick={this.props.forceRefresh} - /> - - {slice.description && ( - <ActionMenuItem - text={t('Toggle chart description')} - tooltip={t('Toggle chart description')} - onClick={this.toggleExpandSlice} - /> - )} - - <ActionMenuItem - text={t('Edit chart')} - tooltip={t("Edit the chart's properties")} - href={slice.edit_url} - target="_blank" - /> - - <ActionMenuItem - text={t('Export CSV')} - tooltip={t('Export CSV')} - onClick={this.exportCSV} - /> - - <ActionMenuItem - text={t('Explore chart')} - tooltip={t('Explore chart')} - onClick={this.exploreChart} - /> - </DropdownButton> + <div bsRole="toggle" className="slice-header-controls-trigger"> Review comment: `bsRole` is throwing an unknown prop error ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org