graceguo-supercat commented on a change in pull request #4893: add sticky to
sidepane
URL:
https://github.com/apache/incubator-superset/pull/4893#discussion_r186245012
##########
File path: superset/assets/src/dashboard/stylesheets/builder-sidepane.less
##########
@@ -1,55 +1,62 @@
.dashboard-builder-sidepane {
- background: white;
- flex: 0 0 376px;
- border: 1px solid @gray-light;
+ flex: 0 0 374px;
z-index: 10;
position: relative;
+ overflow-x: hidden;
+ box-shadow: -4px 0 4px 0 rgba(0, 0, 0, 0.1);
.dashboard-builder-sidepane-header {
font-size: 15px;
font-weight: 700;
+ border-top: 1px solid @gray-light;
border-bottom: 1px solid @gray-light;
- padding: 14px;
+ padding: 16px;
}
.trigger {
- height: 25px;
+ height: 18px;
width: 25px;
- color: @gray;
- position: relative;
-
- &.close {
- top: 3px;
- }
-
- &.open {
- position: absolute;
- right: 14px;
- }
+ color: @almost-black;
+ float: none;
+ opacity: 1;
}
- .component-layer {
- .new-component.static {
- cursor: pointer;
- }
+ .viewport {
+ position: absolute;
+ background: white;
+ overflow: hidden;
+ width: 374px;
Review comment:
yes. use variable is much better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
