hughhhh commented on a change in pull request #4914: [WiP] make MetricsControl 
the standard across visualizations
URL: 
https://github.com/apache/incubator-superset/pull/4914#discussion_r186555521
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -43,6 +43,11 @@
 config = app.config
 stats_logger = config.get('STATS_LOGGER')
 
+METRIC_KEYS = {
 
 Review comment:
   nit: `[]` over `{}`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to