GabeLoins commented on a change in pull request #4914: [WiP] make
MetricsControl the standard across visualizations
URL:
https://github.com/apache/incubator-superset/pull/4914#discussion_r187758524
##########
File path: superset/viz.py
##########
@@ -202,7 +222,7 @@ def query_obj(self):
"""Building a query object"""
form_data = self.form_data
gb = form_data.get('groupby') or []
- metrics = form_data.get('metrics') or []
+ metrics = self.all_metrics or []
Review comment:
The UI does a pretty good job right now informing users that they do not
have a metric selected and preventing them from issuing queries. I'm not sure
what situations there could be where a user could submit a query from explore
without a metric selected, but I am all for informative error messages. I still
think its good to have an idea of when this could happen so the error message
offers the right information. Is this if there's a bug in the UI? Or are there
cases where the UI is working and someone still can press `Run Query` with no
metric selected? See:
https://github.com/apache/incubator-superset/blob/master/superset/assets/src/explore/controls.jsx#L176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
