mistercrunch commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189029182
##########
File path: superset/sql_lab.py
##########
@@ -171,6 +171,7 @@ def handle_error(msg):
# Limit enforced only for retrieving the data, not for the CTA queries.
superset_query = SupersetQuery(rendered_query)
executed_sql = superset_query.stripped()
+ SQL_MAX_ROWS = int(app.config.get('SQL_MAX_ROW', None))
Review comment:
`None` is implicit on the get method and will make `int` raise
```
In [1]: int(None)
TypeError: int() argument must be a string, a bytes-like object or a number,
not 'NoneType'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
