john-bodley opened a new pull request #5028: [druid] Fixing Druid version check
   While investigation another issue with @GabeLoins we realized that the Druid 
version check was invalid, i.e., per the comment on line #626 this issue was 
fixed in `0.8.2`, yet the following condition 
    not self.version_higher(self.cluster.druid_version, '0.8.2')
   returns `True` for any version less than or equal to `0.8.2` rather than 
being exclusive of `0.8.2` since this is the version which included the fix. 
The same logic was wrong on line #646.
   The fix is to use `distutils.version.StrictVersion` for version checking 
which abides by [Druid's semantic 
   to: @GabeLoins @mistercrunch 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to