GabeLoins opened a new pull request #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030 In the AdhocMetric feature, we construct Druid queries by taking a column object and an aggregate from the user and construct a druid JSON blob in the flask app. However, the query object is not always a function of just the column's type and the aggregate chosen. Depending on the Druid version being used, we want to sum floats using `doubleSum` in versions earlier than 11.0.0 and sum floats using `floatSum` in versions including and after 11.0.0 A great explanation of why this is the case is provided here: https://groups.google.com/forum/#!topic/druid-development/VEYkW_5dWd8 reviewers: @john-bodley @michellethomas @mistercrunch @betodealmeida
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
