codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=h1) Report > Merging [#5023](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5505c116ba9cf75f36fffdf562c6ebe8c11e436f?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `86.95%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5023/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5023 +/- ## ========================================== + Coverage 77.34% 77.35% +0.01% ========================================== Files 44 44 Lines 8668 8688 +20 ========================================== + Hits 6704 6721 +17 - Misses 1964 1967 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.64% <ø> (ø)` | :arrow_up: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.67% <100%> (+0.4%)` | :arrow_up: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.74% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.7% <82.35%> (-0.2%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=footer). Last update [5505c11...d7eb638](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org