michellethomas commented on a change in pull request #5032: [Explore][Adhoc
Filters] Expanding the Adhoc Filter popover when the content expands
URL:
https://github.com/apache/incubator-superset/pull/5032#discussion_r189660899
##########
File path: superset/assets/src/explore/components/AdhocFilterEditPopover.jsx
##########
@@ -78,6 +79,13 @@ export default class AdhocFilterEditPopover extends
React.Component {
document.removeEventListener('mousemove', this.onMouseMove);
}
+ adjustHeight(heightDifference) {
+ this.setState(state => ({
+ ...state,
+ height: state.height + heightDifference,
Review comment:
Just curious, is there a specific reason to add the height difference
instead of just strictly setting the new height?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
