codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=h1) Report > Merging [#5021](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce0011e5fcacf8510142353df6c3cf530c04b1c2?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5021 +/- ## ========================================= + Coverage 77.35% 77.46% +0.1% ========================================= Files 44 44 Lines 8677 8683 +6 ========================================= + Hits 6712 6726 +14 + Misses 1965 1957 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.22% <100%> (+1.8%)` | :arrow_up: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=footer). Last update [ce0011e...f1db6f9](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
