michellethomas commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391081201 For `Start/End` it would be nice to have the language make it clear if the range will be inclusive or exclusive. Druid and sqlalchemy data sources do not filter on the date ranges as both inclusive, and it can be especially confusing when looking at sums over a range (like in big number or table viz). It could be nice if druid/sqlalchemy were consistent, but changing it now would make existing slices incorrect (as people have adjusted to this difference). When we move to using druid sql, this will be consistent. I'll try to look around more for specific suggestions. Maybe something like `Starting after` and `Up to`? It's a little verbose though.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
