michellethomas commented on a change in pull request #5057: Translate string to
array for multi fields in getControlsState
URL:
https://github.com/apache/incubator-superset/pull/5057#discussion_r190359546
##########
File path: superset/assets/src/explore/store.js
##########
@@ -56,6 +56,10 @@ export function getControlsState(state, form_data) {
delete control.mapStateToProps;
}
+ if (control.multi && typeof formData[k] === 'string') {
Review comment:
I think we'd want to stick with `typeof formData[k] === 'string'` because
formData[k] might be undefined or null and we would want to leave it as null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
