mistercrunch commented on a change in pull request #4726: [bugfix] convert
metrics to numeric in dataframe
URL:
https://github.com/apache/incubator-superset/pull/4726#discussion_r194572936
##########
File path: superset/viz.py
##########
@@ -170,11 +170,21 @@ def get_df(self, query_obj=None):
if self.datasource.offset:
df[DTTM_ALIAS] += timedelta(hours=self.datasource.offset)
df[DTTM_ALIAS] += self.time_shift
+
+ self.df_metrics_to_num(df, query_obj.get('metrics') or [])
+
df.replace([np.inf, -np.inf], np.nan)
fillna = self.get_fillna_for_columns(df.columns)
df = df.fillna(fillna)
return df
+ @staticmethod
+ def df_metrics_to_num(df, metrics):
+ """Converting metrics to numeric when pandas.read_sql cannot"""
+ for col, dtype in df.dtypes.items():
+ if dtype.type == np.object_ and col in metrics:
+ df[col] = pd.to_numeric(df[col])
Review comment:
@michellethomas what do you think of
https://github.com/apache/incubator-superset/pull/5176 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
