mistercrunch commented on a change in pull request #5216: [sqllab] Fix sql lab
resolution link
URL:
https://github.com/apache/incubator-superset/pull/5216#discussion_r196132172
##########
File path: superset/assets/src/SqlLab/components/ResultSet.jsx
##########
@@ -155,7 +155,11 @@ export default class ResultSet extends
React.PureComponent {
if (query.state === 'stopped') {
return <Alert bsStyle="warning">Query was stopped</Alert>;
} else if (query.state === 'failed') {
- return <Alert bsStyle="danger">{query.errorMessage}</Alert>;
+ return (
+ <Alert bsStyle="danger">
+ {query.errorMessage}
+ {query.link && <a href={query.link}> (Common errors and their
resolutions)</a>}
Review comment:
Let's use a `i18n` string `{t('(Common errors and their resolutions)')}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
