williaster commented on a change in pull request #5213: [fix] new dashboard
state
URL:
https://github.com/apache/incubator-superset/pull/5213#discussion_r196249207
##########
File path: superset/assets/src/dashboard/reducers/getInitialState.js
##########
@@ -18,11 +18,13 @@ import {
} from '../util/componentTypes';
export default function(bootstrapData) {
+ // ignore editMode flag from server side.
Review comment:
@graceguo-supercat why does it need that? can you not add a chart to a v1
dashboard from explorer, then get dumped in a v1 dashboard in view mode? then
toggle edit mode if need be?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
