graceguo-supercat commented on a change in pull request #5213: [fix] new
dashboard state
URL:
https://github.com/apache/incubator-superset/pull/5213#discussion_r196601836
##########
File path: superset/assets/src/dashboard/reducers/getInitialState.js
##########
@@ -18,11 +18,13 @@ import {
} from '../util/componentTypes';
export default function(bootstrapData) {
+ // ignore editMode flag from server side.
Review comment:
editMode=true flag is set from explore view
https://github.com/apache/incubator-superset/blob/c18ef8903409c20b8526b9acd12d3ba1c4c3664b/superset/assets/src/explore/components/SaveModal.jsx#L111
i just feel it's too many hassle to bring this dashboard logic (preview?
version1 ? version2?) to explore view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
