williaster edited a comment on issue #5253: Revert "[perf] add webpack 4 + SplitChunks + lazy load visualizations" URL: https://github.com/apache/incubator-superset/pull/5253#issuecomment-398845522 LGTM 😢 Specifically the global notify package is breaking this (we should not have global packages ... dashboard v2 introduces a redux-based notification system), and I'm not sure what the cause of the duplicate resource requests (for things like theme/font) is but this is an example <img width="500" alt="screen shot 2018-06-20 at 10 31 36 am" src="https://user-images.githubusercontent.com/4496521/41676597-e3fc9a1a-747a-11e8-9cfc-162e52303616.png";>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4496521/41676597-e3fc9a1a-747a-11e8-9cfc-162e52303616.png"](https://user-images.githubusercontent.com/4496521/41676597-e3fc9a1a-747a-11e8-9cfc-162e52303616.png"){kind=link}