john-bodley edited a comment on issue #5256: [slice] Adding slice owners to SliceFilter URL: https://github.com/apache/incubator-superset/pull/5256#issuecomment-399158094 The right solutuon is to fix the permission logic for slices and datasources. This is quite involved as it would require deprecating the slice/datasource perm field and instead use the datasource’s db, schema, and table name for permission checking. In the case of custom SQL if there's no datasource permission which matches it should probably pass the SQL (not unlike SQL Lab) to determine the physical underlying tables/views and then check their permissions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
