williaster commented on a change in pull request #5218: [fix] layout converter
fix
URL:
https://github.com/apache/incubator-superset/pull/5218#discussion_r197305078
##########
File path: superset/assets/src/dashboard/util/propShapes.jsx
##########
@@ -59,8 +59,8 @@ export const slicePropShape = PropTypes.shape({
datasource: PropTypes.string,
datasource_name: PropTypes.string,
datasource_link: PropTypes.string,
- changedOn: PropTypes.number,
- modified: PropTypes.string,
+ changed_on: PropTypes.number.isRequired,
+ modified: PropTypes.string.isRequired,
Review comment:
thanks for the context! makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
