john-bodley commented on a change in pull request #5267: [hive-csv] Infer
schema from csv
URL:
https://github.com/apache/incubator-superset/pull/5267#discussion_r197595086
##########
File path: superset/config.py
##########
@@ -314,6 +314,14 @@ class CeleryConfig(object):
# contain all the external tables
CSV_TO_HIVE_UPLOAD_DIRECTORY = 'EXTERNAL_HIVE_TABLES/'
+# This contains the mappings from the tableschema types to HIVE types
+TABLESCHEMA_TO_HIVE_TYPES = {
Review comment:
I think this probably belongs in `db_engine_spec`. I agree this isn't
cut-and-dry as different versions of Hive support different types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
