john-bodley commented on a change in pull request #5268: [hive-csv] specify
hive namespace for tables
URL:
https://github.com/apache/incubator-superset/pull/5268#discussion_r197595482
##########
File path: superset/db_engine_specs.py
##########
@@ -978,6 +978,14 @@ def get_column_names(filepath):
return next(unicodecsv.reader(f, encoding='utf-8-sig'))
table_name = form.name.data
+ if config.get('UPLOADED_CSV_HIVE_NAMESPACE'):
+ if '.' in table_name:
+ raise Exception(
+ "You can't specify a namespace."
+ 'All tables will be uploaded to the `{}` namespace'.format(
Review comment:
I would probably use `'` rather than a backtick here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
